Skip to content

Conversation

@ofalk
Copy link

@ofalk ofalk commented Feb 20, 2018

No description provided.

@ofalk ofalk changed the base branch from master to develop February 20, 2018 07:30
@ofalk
Copy link
Author

ofalk commented Feb 20, 2018

@razorsedge Not 100 % sure if this is opened correctly now, please let me know!

@ofalk
Copy link
Author

ofalk commented Mar 2, 2018

@razorsedge Any chance this gets merged?

@razorsedge
Copy link
Owner

@ofalk A quick look at your code does not raise any concerns (README update and tests are present) however all of the "Merge branch" commits cannot be present. Did you start from the master branch and then switch to develop?

@ofalk
Copy link
Author

ofalk commented Mar 5, 2018

@razorsedge : Yes, that's what I did, started from master and then switched to develop. So close this PR and open new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants