Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appeal revoke on deleted resources is not working #299

Open
singhvikash11 opened this issue Sep 29, 2022 · 1 comment
Open

Appeal revoke on deleted resources is not working #299

singhvikash11 opened this issue Sep 29, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@singhvikash11
Copy link
Member

singhvikash11 commented Sep 29, 2022

Description
failed to revoke an appeal for an underlying resource if the resource got renamed or deleted. We have access report comparison where we have requested in guardian doesn't exist into GCP big query. These resources don't exist on GCP since people delete the dataset or renamed it and revoke of appeal failed with an error to find the same resource in GCP.

Expected behaviour
Either soft-delete on a resource during fetch resources will revoke these appeals or the appeal can handle in case a resource doesn't exist.

@bsushmith
Copy link
Member

@singhvikash11 can a resource be deleted and recreated later with the same name?

For example, in bigquery, if one deletes a dataset named - city_flags, and later someone else creates a dataset with same name...

In this scenario, I would assume - that guardian would revoke appeals at the time when the initial dataset was deleted.
Because if it did not revoke at the time of resource deletion, the dataset recreated later in bigquery would not have the user access to it but the guardian grants table would show that the user still has access.

@rahmatrhd @mabdh WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants