Skip to content

Commit 185ee90

Browse files
authored
test: fix inconsistent test due to unordered slices comparison (#355)
* test: fix inconsistent test due to map comparison * chore: use cmp diff to sort the slices * fix: sort related permissions
1 parent 134681e commit 185ee90

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

plugins/providers/bigquery/provider.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"errors"
66
"fmt"
7+
"sort"
78
"strings"
89
"sync"
910
"time"
@@ -317,6 +318,7 @@ func (p *Provider) GetActivities(ctx context.Context, pd domain.Provider, filter
317318
}
318319
}
319320
a.RelatedPermissions = slices.UniqueStringSlice(a.RelatedPermissions)
321+
sort.Strings(a.RelatedPermissions)
320322

321323
activities = append(activities, a)
322324
}

plugins/providers/bigquery/provider_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"time"
1010

1111
"cloud.google.com/go/logging"
12+
"github.com/google/go-cmp/cmp"
1213
"github.com/odpf/guardian/core/provider"
1314
"github.com/odpf/guardian/domain"
1415
"github.com/odpf/guardian/plugins/providers/bigquery"
@@ -1148,7 +1149,7 @@ func (s *BigQueryProviderTestSuite) TestGetActivities_Success() {
11481149
s.mockCloudLoggingClient.AssertExpectations(s.T())
11491150
s.mockBigQueryClient.AssertExpectations(s.T())
11501151
s.NoError(err)
1151-
s.Equal(expectedActivities, actualActivities)
1152+
s.Empty(cmp.Diff(expectedActivities, actualActivities))
11521153
})
11531154

11541155
s.Run("should return error if there is an error on initializing logging client", func() {

0 commit comments

Comments
 (0)