Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline local variable #44

Open
Jolanrensen opened this issue Dec 28, 2022 · 4 comments
Open

Multiline local variable #44

Jolanrensen opened this issue Dec 28, 2022 · 4 comments
Assignees

Comments

@Jolanrensen
Copy link

Hi!

I was wondering whether it would/could be possible to define a //#local variable using a multiline string.
I want to use JCP to reuse documentation for many function overloads and while I can define the documentation in gradle, I think it would be better to define them in the same file they are reused.
This is already possible:

//#local ADD = " * Original [DataFrame] is not modified.\n *\n * @throws [DuplicateColumnNamesException] if columns in expected result have repeated names\n * @throws [UnequalColumnSizesException] if columns in expected result have different sizes\n * @return new [DataFrame] with added columns"

/**
 * Creates new [DataFrame] with given columns added to the end of original [DataFrame.columns] list.
 *
/*$ADD$*/
 * @param columns columns to add
 */
public fun <T> DataFrame<T>.add(vararg columns: AnyBaseCol): DataFrame<T> = addAll(columns.asIterable())

But you can imagine that writing long documentation on the same line would be a hassle. Is there a notation possible with JCP that allows for something like this?

//#local ADD = """ * Original [DataFrame] is not modified.
//# *
//# * @throws [DuplicateColumnNamesException] if columns in expected result have repeated names
//# * @throws [UnequalColumnSizesException] if columns in expected result have different sizes
//# * @return new [DataFrame] with added columns"""
@raydac
Copy link
Owner

raydac commented Dec 28, 2022

may be it would be easy just to load multiline file with evalfile() function?

@Jolanrensen
Copy link
Author

That works too! Thanks!
But I do like having the documentation in the same file so I can check that references to other classes work. (Also helps with refactoring)
For example:

import org.jetbrains.kotlinx.dataframe.DataFrame
import org.jetbrains.kotlinx.dataframe.exceptions.DuplicateColumnNamesException
import org.jetbrains.kotlinx.dataframe.exceptions.UnequalColumnSizesException


/**
//#local ADD0 = " * Original [DataFrame] is not modified."
//#local ADD1 = " *"
//#local ADD2 = " * @throws [DuplicateColumnNamesException] if columns in expected result have repeated names"
//#local ADD3 = " * @throws [UnequalColumnSizesException] if columns in expected result have different sizes"
//#local ADD4 = " * @return new [DataFrame] with added columns"
//
//#local ADD = ADD0 + "\n" + ADD1 + "\n" + ADD2 + "\n" + ADD3 + "\n" + ADD4
 */


/**
 * Creates new [DataFrame] with given columns added to the end of original [DataFrame.columns] list.
 *
/*$ADD$*/
 * @param columns columns to add
 */
public fun <T> DataFrame<T>.add(vararg columns: AnyBaseCol): DataFrame<T> = addAll(columns.asIterable())

If I don't link to, for instance, UnequalColumnSizesException from a documentation part, the linter will remove it from the imports, breaking the link when it gets pasted at the other methods.

For this, a multiline string would be ideal, unless you know another way to achieve what I want in an easy-to-use manner :)

@Jolanrensen
Copy link
Author

I'll probably go another route for my particular issue, but I do think that, aside from multi-line strings, also multi-line statements could be a great addition to JCP.

Like

//#local VAR = "a" +
//# "test"

Just my 2 cents

@raydac
Copy link
Owner

raydac commented Dec 30, 2022

the preprocesser was developed to process line by line, not any char stream, so that there should be different approach, may be some function or directive which will be filling some variable by following block of strings

@raydac raydac self-assigned this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants