-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse typeid #17067
base: main
Are you sure you want to change the base?
parse typeid #17067
Conversation
Thank you for your contribution! 🎉 🔔 @jmaeso @GastroGeek @pernielsentikaer @LunaticMuch @hmarr @harsh-devx @lukas-runge you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
"@eslint/compat": "^1.2.6", | ||
"@eslint/eslintrc": "^3.2.0", | ||
"@eslint/js": "^9.20.0", | ||
"@raycast/eslint-config": "^1.0.11", | ||
"@types/node": "^22.13.4", | ||
"@types/uuid": "^10.0.0", | ||
"eslint": "^8.45.0", | ||
"eslint-plugin-import": "^2.27.5", | ||
"react-devtools": "^4.28.0", | ||
"typescript": "^5.1.6" | ||
"@typescript-eslint/eslint-plugin": "^8.24.0", | ||
"eslint": "^9.20.1", | ||
"eslint-plugin-import": "^2.31.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to keep packages up to date to avoid weird old compatibility issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, @raycast/api
does not support ESLint 9 yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, interesting, that's why this was harder than I expected :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove .eslintrc.json? I should probably still exists with
{
"root": true,
"extends": ["@raycast"]
}
@@ -0,0 +1,43 @@ | |||
import typescriptEslint from "@typescript-eslint/eslint-plugin"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? Didn't try to remove it, but this definitely the way configuration is done in the latest ESLint version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this. You can refer to other extensions' configurations since you changed ESLint back to version 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds TypeID parsing functionality to the UUID Generator extension, allowing users to decode TypeIDs back into UUIDs with copy/paste support.
- New
parseTypeID.ts
could useshowFailureToast
from@raycast/utils
instead of manualshowToast
with failure style launchCommand
inparseTypeID.ts
should be wrapped in try/catch block for better error handling- Consider adding subtitle "UUID Generator" to commands in
package.json
since there are multiple commands - Ensure
metadata
folder exists with screenshots since this extension has view commands - Changelog entry uses
{PR_MERGE_DATE}
correctly for automatic date replacement
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
rules: { | ||
"@typescript-eslint/no-unused-vars": [ | ||
"warn", | ||
{ | ||
"argsIgnorePattern": "^_", | ||
"varsIgnorePattern": "^_", | ||
"caughtErrorsIgnorePattern": "^_" | ||
} | ||
], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Indentation is inconsistent in the rules section (extra spaces before @typescript-eslint/no-unused-vars and misaligned closing bracket)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better not to bring some of your preferred rules to this project. Keeping all extension code styles consistent is good for the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we should use the default esline config only:
{
"printWidth": 120,
"singleQuote": false
}
"name": "parseTypeID", | ||
"title": "Parse TypeIDs", | ||
"description": "Parse TypeID and copy resulting UUID to the clipboard", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a subtitle 'UUID Generator' to maintain consistency with other commands in the extension
@@ -1,5 +1,6 @@ | |||
{ | |||
"devDependencies": { | |||
"@typescript-eslint/eslint-plugin": "^8.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider pinning exact version instead of using ^ to ensure consistent builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could ignore this one. Just remove this plugin and use Raycast's default configuration about ESLint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree 🙂
I don't have much more time to put into this. I was more ambitious than I should have been with the eslint upgrades and such, but we can ignore that and fix it up later, it would be great to get this merged. I don't have the time to fix that up. |
Description
Add typeid parsing support.
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder