Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] action_masking_example.py fails - RLModule build fails with "unexpected keyword argument 'observation_space'" #48877

Open
PhilippWillms opened this issue Nov 22, 2024 · 0 comments · May be fixed by #48885
Labels
bug Something that is supposed to be working; but isn't rllib RLlib related issues triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@PhilippWillms
Copy link

What happened + What you expected to happen

Running the action_masking_rl_module.py example, which is shipped with 2.39 release, fails at RLModule instantiation.

File "C:\Users\Philipp\anaconda3\envs\py311-raynew\Lib\site-packages\ray\rllib\core\rl_module\rl_module.py", line 100, in build
module = self.module_class(
^^^^^^^^^^^^^^^^^^
TypeError: ActionMaskingRLModule.init() got an unexpected keyword argument 'observation_space'

I did no change to the file locally. I skipped the CLI args "--enable-new-api-stack", as for PPO the new API stack is enabled by default since of release 2.39

Versions / Dependencies

python==3.11.9
ray===2.39.0
torch==2.3.1+cu118
gymnasium==1.0.0

Reproduction script

python ray/rllib/examples/rl_modules/action_masking_rl_module.py

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@PhilippWillms PhilippWillms added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 22, 2024
@jcotant1 jcotant1 added the rllib RLlib related issues label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't rllib RLlib related issues triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants