Duplicate friend list

[mrpond]

rAthena Hash

a44d954

Client Date

20131120

Server Mode

Pre-Renewal, Renewal

Result

character server will print error when try to insert duplicate friend id into table

Relevant Log Output

N/A

Expected Result

fix
rAthena\src\char\char.cpp

int char_mmo_char_tosql(uint32 char_id, struct mmo_charstatus* p){
...
		StringBuf_Printf(&buf, "INSERT INTO `%s` (`char_id`, `friend_id`) VALUES ", schema_config.friend_db);
//===
		for (size_t index_friend = 0; index_friend < MAX_FRIENDS; ++index_friend) {
			if (p->friends[index_friend].char_id > 0) {
				for (size_t lookup = 0; lookup < MAX_FRIENDS; ++lookup) {
					if (index_friend != lookup) {
						if (p->friends[index_friend].char_id == p->friends[lookup].char_id) {
							p->friends[lookup].char_id = 0;
						}
					}
				}
			}
		}
//===
		for( i = 0, count = 0; i < MAX_FRIENDS; ++i )
...

How to Reproduce

N/A

Official Information

N/A

Modifications that may affect results

No response

[Lemongrass3110]

Originally reported in #5277. We did not get feedback to our questions there.

Since we do not know how to reproduce it, we are unable to fix this.

Do you know the necessary steps to reproduce this issue?

[mrpond]

Originally reported in #5277. We did not get feedback to our questions there.

Since we do not know how to reproduce it, we are unable to fix this.

Do you know the necessary steps to reproduce this issue?

no, I don't know how to reproduce it. error happen when character to save the data into table.
Server had around 1800 players. and it happen randomly