Splash Damage bypass Walls and Line of Sight

[LadyNanuia]

rAthena Hash

5ff0419

Client Date

2023-11-10

Server Mode

Renewal

Result

Having high amounts of bonus bSplashAddRange,n; on your character will cause your splash attacks to bypass Walls / Line of sight, tiggering Rude attack teleport scripts on monsters , sometimes even killing them so they drop loot that you cannot reach

Relevant Log Output

None

Expected Result

It should be bound by line of sight like skills are / walls

How to Reproduce

Latest Ra, make a character and some items, put a lot of bonus bSplashAddRange,n; on items and auto attack monsters while having monsters who are "in range" but out of line of sight / behind walls, will still get hit and trigger rudescript / die and drop loot you cannot reach.

Official Information

Unsure but im 99% sure it shouldnt work this way

Modifications that may affect results

None

[LadyNanuia]

in the screenshot above you can see the Miniming (on another platform) which is out of line of sight , gets hit & aggros from us auto attacking our main target

[Playtester]

skill.cpp

				skill_area_temp[1] = bl->id;
				map_foreachinallrange(skill_area_sub, bl,
					sd->bonus.splash_range, BL_CHAR,
					src, skill_id, skill_lv, tick, flag | BCT_ENEMY | 1,
					skill_castend_damage_id);
				flag|=1; //Set flag to 1 so ammo is not double-consumed. [Skotlex]

This should probably be using "map_foreachinshootrange" instead.

But there's no official item that gives more than 1 splash range.

[LadyNanuia]

skill.cpp

				skill_area_temp[1] = bl->id;
				map_foreachinallrange(skill_area_sub, bl,
					sd->bonus.splash_range, BL_CHAR,
					src, skill_id, skill_lv, tick, flag | BCT_ENEMY | 1,
					skill_castend_damage_id);
				flag|=1; //Set flag to 1 so ammo is not double-consumed. [Skotlex]

This should probably be using "map_foreachinshootrange" instead.

But there's no official item that gives more than 1 splash range.

ah i see, since baphomet is the only official source im assuming? well ill try the fix and if it works ill let you know, thanks for the reply

[Playtester]

It's also used by Shotguns, but that's also just 3x3.