Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@whodrops not work correctly with addmonsterdrop #7845

Open
vietlubu opened this issue Jul 11, 2023 · 2 comments · May be fixed by #8049
Open

@whodrops not work correctly with addmonsterdrop #7845

vietlubu opened this issue Jul 11, 2023 · 2 comments · May be fixed by #8049
Labels
type:bug Issue that is a bug within rAthena

Comments

@vietlubu
Copy link
Contributor

rAthena Hash

fe4234c

Client Date

2021-11-03

Server Mode

Renewal

Result

@whodrops show duplicate results for item set drop by addmonsterdrop

  • Script add: addmonsterdrop 1001,1001253,10000,1;
  • Result: Correct

  • Script add:
addmonsterdrop 1001,1001253,10000,1;
addmonsterdrop 1002,1001253,10000,1;
  • Result: incorrect
    image

  • Script add:
addmonsterdrop 1001,1001253,10000,1;
addmonsterdrop 1002,1001253,10000,1;
addmonsterdrop 1004,1001253,10000,1;
  • Result: incorrect
    image

If I reload script instead of restart server, many duplicate show out.

Relevant Log Output

No response

Expected Result

@whodrops show correct result

How to Reproduce

  1. Add test script
-	script	addmonsterdrop	-1,{
OnInit:
    
	delmonsterdrop 1001,1001253;
	delmonsterdrop 1002,1001253;
	delmonsterdrop 1004,1001253;

	addmonsterdrop 1001,1001253,10000,1;
	addmonsterdrop 1002,1001253,10000,1;
	addmonsterdrop 1004,1001253,10000,1;

	// delmonsterdrop 1001,1001253;
	// delmonsterdrop 1002,1001253;
	// delmonsterdrop 1004,1001253;

	end;
}

  1. Use @whodrops 1001253 in game

  2. Note:

  • If I reload script instead of restart server, many duplicate show out.
  • I had tried to use delmonsterdrop after addmonsterdrop. Using @mi 1002 is correct. but @whodrops stilling show deleted drop item.
  • @whodrops cached drop item added by addmonsterdrop?

Official Information

No

Modifications that may affect results

No response

@vietlubu vietlubu added the type:bug Issue that is a bug within rAthena label Jul 11, 2023
@gidzdlcrz
Copy link

gidzdlcrz commented Sep 8, 2023

This was already tackled in #2016

@vietlubu
Copy link
Contributor Author

This was already tackled in #2016

I think that is difference issue.

vstumpf added a commit to vstumpf/rathena that referenced this issue Dec 26, 2023
Don't reload the entire db when adding or deleting drops
Fixes rathena#7845
@vstumpf vstumpf linked a pull request Dec 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Issue that is a bug within rAthena
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants