-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SPDX license tags in pyproject.toml #152
Comments
What about using |
|
Wow. I'm just catching up here -- I had no idea that I was touching something that was recently changed. Apparently setuptools does not yet support license expressions in This PR to setuptools will add PEP 639 license expression support. pypa/setuptools#4706 I am going to cancel this endeavor until a future time. |
@eriknw Once tooling (setuptools) catches up to PEP 639, I think we want to continue specifying
|
Wonder if as a first step we could do this? [project]
-license = { text = "Apache 2.0" }
+license = { text = "Apache-2.0" } Namely ensure the text field itself is SPDX compatible Looks like that is true in several projects (though not all) |
@jakirkham I think your proposal is a good next step. This work is motivated by the rattler-build transition. If rattler-build complains about I proposed that in the original thread that prompted this issue: rapidsai/rmm#1796 (comment) |
We want to use SPDX license identifiers in
pyproject.toml
files, following the Python Packaging Docs on thelicense
field.Today we define our licenses in a way that was meant to pass wheeltamer, an internal check for wheels which is no longer used.
Therefore we should replace this:
with this (note the dash, which makes this a valid SPDX identifier):
Specifically, this change conforms to: https://peps.python.org/pep-0639/#deprecate-license-key-table-subkeys
The text was updated successfully, but these errors were encountered: