Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Noticeable text update #491

Closed
MrPandir opened this issue Apr 23, 2024 · 12 comments
Closed

[Bug] Noticeable text update #491

MrPandir opened this issue Apr 23, 2024 · 12 comments

Comments

@MrPandir
Copy link
Contributor

When I enter docker stats I see the text update every second and the cursor momentarily jumps to the beginning.
This does not happen in Apple Terminal.
But this does not happen with programs that refresh the entire screen such as btop or htop and are displayed correctly.

Videos

Screen.Recording.2024-04-23.at.15.06.09.mov
Screen.Recording.2024-04-23.at.15.07.27.mov

Additional Information

Rio Version: 0.0.36
OS: macOS 14.4
Config:

cursor = ''
blinking-cursor = false
confirm-before-quit = false
[navigation]
mode = "CollapsedTab"
@raphamorim
Copy link
Owner

Hey @MrPandir, thanks for the issue.

Yes I am aware of it, should be fixed in the upcoming version of Rio (0.1.0) that does compute visual diffs before clean and redraw.

@raphamorim
Copy link
Owner

This issue should not be able to reproduce with the latest release (v0.1.0) since Rio now does not compute render on the same data tree, closing this issue for now. In case find anything odd we can reopen or create a new issue.

@MrPandir
Copy link
Contributor Author

Unfortunately this was not fixed in version 0.1.0

Screen.Recording.2024-06-11.at.09.41.54.mov

@raphamorim
Copy link
Owner

Yea, I can reproduce as well. Reopening this issue.

@raphamorim raphamorim reopened this Jun 11, 2024
@raphamorim
Copy link
Owner

raphamorim commented Aug 18, 2024

@MrPandir could you test with main branch?

Actually nevermind, I figured out the fix but I want to do it properly 👌

@MrPandir
Copy link
Contributor Author

Yes, I confirm this has been fixed. 👍

@raphamorim
Copy link
Owner

In the latest main? ecc4270

@MrPandir
Copy link
Contributor Author

In the latest main? ecc4270

No, it wasn't fixed. It seems you rolled back the changes.

@raphamorim
Copy link
Owner

Yup! will do a proper fix for it but at least figured out the issue haha :D

@raphamorim
Copy link
Owner

@MrPandir could you test main again?

@MrPandir
Copy link
Contributor Author

@MrPandir could you test main again?

Yes, that has been fixed. 👍

Screen.Recording.2024-08-22.at.09.58.12.mov

@raphamorim
Copy link
Owner

That’s great! Thanks for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants