Extensions: Add hooks to support virtual clusters #11064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
2 times, most recently
from
7e09964
to
1e4174c
Compare
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
3225ac2
to
82fc100
Compare
|
@mantis-toboggan-md finally got this to pass gates - refactored as we discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11065
This PR adds several hooks for virtual cluster support.
The changes extend the provisioner helper and allow the cluster list to be grouped by host cluster when there are virtual clusters present.
Changes made in a way to be as least disruptive as possible.
We will refine these extension points in the future and document once stable.
Areas or cases that should be tested
These hooks will be tested by extensions.
Current e2e test should validate that the hooks do not break existing functionality.
Checklist