Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a button to retry checking for updates #7516

Open
jsoref opened this issue Sep 19, 2024 · 14 comments · May be fixed by #8189
Open

Offer a button to retry checking for updates #7516

jsoref opened this issue Sep 19, 2024 · 14 comments · May be fixed by #8189
Labels
area/installer For the installer, updater and uninstaller. kind/enhancement New feature or request

Comments

@jsoref
Copy link
Contributor

jsoref commented Sep 19, 2024

Problem Description

I'm not precisely sure what I did, but it's possible my laptop moved between networks/was on a broken network...

Rancher Desktop 1.15.0 showed me:
image

There was no obvious way to get it to check again. (Exiting and restarting did eventually get me an update prompt, which did let me get 1.15.1 in time to be told by @jandubois that there's a 1.16.0, but that's another story.)

Proposed Solution

Add a button to check for updates to the failed flow

Additional Information

#1929 talks about cases where some update check fails.

@jsoref jsoref added the kind/enhancement New feature or request label Sep 19, 2024
@Anutrix
Copy link

Anutrix commented Oct 15, 2024

Been waiting for this forever.

@jandubois jandubois added the area/installer For the installer, updater and uninstaller. label Oct 15, 2024
@VikalpRusia
Copy link
Contributor

What would be the suitable place to place retry button?

  • at the top beside Update available
  • at the bottom after release notes ( where apply update button appears when successful )

My suggestion would be to place it beside update available.
@jandubois , @mook-as need your inputs before I start implementing

@jsoref
Copy link
Contributor Author

jsoref commented Feb 4, 2025

Personally, I'd be inclined to put it next to update available. But if you put it there, the button shouldn't be labeled "Retry", just "Check for updates"

But, arguably any place would be fine. Technically, it's logically more appropriate to put it after "There was an error checking for updates."

@jsoref
Copy link
Contributor Author

jsoref commented Feb 4, 2025

Given that there's already a flow with a button below:
Image

It's probably best to put the button below.

@jandubois
Copy link
Member

jandubois commented Feb 4, 2025

I don't understand the discussion. Why would you need a retry button if you already have the update available?

I thought you just wanted a way to force Rancher Desktop to check for updates right away instead of waiting for up to an hour when it would check again automatically. So the button would only be displayed when there are no release notes.

I think the best placement would be to move the "Check for updates automatically" checkbox to the left to make enough space behind it for a "Check now" button:

Image

@jandubois
Copy link
Member

I thought you just wanted a way to force Rancher Desktop to check for updates right away instead of waiting for up to an hour when it would check again automatically.

Rereading the top of the thread I see now that you had an error situation where the release notes have been fetched, but the update data download has failed. I don't believe this is a common scenario. Did this happen more than once (personally I have never seen it).

@jsoref
Copy link
Contributor Author

jsoref commented Feb 5, 2025

I'm pretty sure we saw it recently on a coworker's laptop...

@VikalpRusia
Copy link
Contributor

VikalpRusia commented Feb 5, 2025

Did this happen more than once
It happened with me once

but I agree with your suggestion @jandubois ,
We can have check for update button which can also do retry when something fails.

@VikalpRusia
Copy link
Contributor

VikalpRusia commented Feb 5, 2025

When there is no failure
Image

When there is failure
Image

@VikalpRusia VikalpRusia linked a pull request Feb 5, 2025 that will close this issue
@jsoref
Copy link
Contributor Author

jsoref commented Feb 5, 2025

Retry Update isn't really correct, that would imply that updating failed and that the button would attempt to update again. This is really Recheck for available updates or something...

@VikalpRusia
Copy link
Contributor

VikalpRusia commented Feb 5, 2025

@jsoref renamed it

@jandubois I had a doubt, commented on the MR itself, could you clarify me please :)

@jandubois
Copy link
Member

I don't think we need different text for failed update checks. It just makes the code more complex for no real benefit. It is also hard to test if that code actually works.

I think the button should just say "Check Now". "[X] Check for updates automatically (Check for Updates)" is less clear than "Check Now" in my opinion.

Something like this (from a different app):

Image

@VikalpRusia
Copy link
Contributor

VikalpRusia commented Feb 5, 2025

@jandubois yup, seems better changed the MR.

Could you help me with this (validating) - #8189 (comment)

@jsoref
Copy link
Contributor Author

jsoref commented Feb 5, 2025

Yes, Check Now is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer For the installer, updater and uninstaller. kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants