-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer a button to retry checking for updates #7516
Comments
Been waiting for this forever. |
What would be the suitable place to place retry button?
My suggestion would be to place it beside update available. |
Personally, I'd be inclined to put it next to update available. But if you put it there, the button shouldn't be labeled "Retry", just "Check for updates" But, arguably any place would be fine. Technically, it's logically more appropriate to put it after "There was an error checking for updates." |
I don't understand the discussion. Why would you need a retry button if you already have the update available? I thought you just wanted a way to force Rancher Desktop to check for updates right away instead of waiting for up to an hour when it would check again automatically. So the button would only be displayed when there are no release notes. I think the best placement would be to move the "Check for updates automatically" checkbox to the left to make enough space behind it for a "Check now" button: |
Rereading the top of the thread I see now that you had an error situation where the release notes have been fetched, but the update data download has failed. I don't believe this is a common scenario. Did this happen more than once (personally I have never seen it). |
I'm pretty sure we saw it recently on a coworker's laptop... |
but I agree with your suggestion @jandubois , |
|
@jsoref renamed it @jandubois I had a doubt, commented on the MR itself, could you clarify me please :) |
I don't think we need different text for failed update checks. It just makes the code more complex for no real benefit. It is also hard to test if that code actually works. I think the button should just say "Check Now". "[X] Check for updates automatically (Check for Updates)" is less clear than "Check Now" in my opinion. Something like this (from a different app): |
@jandubois yup, seems better changed the MR.
|
Yes, |
Problem Description
I'm not precisely sure what I did, but it's possible my laptop moved between networks/was on a broken network...
Rancher Desktop 1.15.0 showed me:

There was no obvious way to get it to check again. (Exiting and restarting did eventually get me an update prompt, which did let me get 1.15.1 in time to be told by @jandubois that there's a 1.16.0, but that's another story.)
Proposed Solution
Add a button to check for updates to the failed flow
Additional Information
#1929 talks about cases where some update check fails.
The text was updated successfully, but these errors were encountered: