Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framed Follow viewfinder conflict with debug_draw_3d addon #296

Open
fhgaha opened this issue May 9, 2024 · 7 comments
Open

Framed Follow viewfinder conflict with debug_draw_3d addon #296

fhgaha opened this issue May 9, 2024 · 7 comments

Comments

@fhgaha
Copy link

fhgaha commented May 9, 2024

Issue description

In this release after running the res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_framed_example_scene.tscn I see this
ga9bOiQkbR
No reaction on mouse movement or keys pressed

Steps to reproduce

In this release run scene res://addons/phantom_camera/examples/example_scenes/3D/3d_follow_framed_example_scene.tscn

(Optional) Minimal reproduction project

No response

I use Godot 4.2.1 GDScript version

@ramokz
Copy link
Owner

ramokz commented May 9, 2024

That doesn't look right. Have no never seen that issue before.

I tried downloading the addon from the AssetLib on a freshly made project.
When I'm running it, I'm seeing the below:
image

@ramokz
Copy link
Owner

ramokz commented May 9, 2024

Are you getting any errors in the Output tab?

@fhgaha
Copy link
Author

fhgaha commented May 14, 2024

Are you getting any errors in the Output tab?

There are no errors. If you are interested, you can try it in my project, where I ran into a problem: https://github.com/fhgaha/snow-car

@ramokz
Copy link
Owner

ramokz commented May 14, 2024

It appears to be caused by the debug_draw_3d addon in your project.
I am not sure why.

@fhgaha
Copy link
Author

fhgaha commented May 14, 2024

Huh! Interesting

@skison
Copy link

skison commented May 21, 2024

I see the same issue in my project - it appears that, somewhere, a CanvasLayer with a ViewfinderPanel control is being instanced and added as a child to the first node in the scene tree. I have to disable all of my Autoload scripts/scenes to see the intended effect (where the CanvasLayer becomes a child of the "Root" Node3D), otherwise it attaches itself to the first Autoload node in the tree.
PhantomCameraViewfinderTreeBug

@ramokz
Copy link
Owner

ramokz commented May 29, 2024

Had another look at this. Don't think the issue is related to where the Viewfinder is instantiated / nested within the scene tree.
Reason being that even when it's a child of the root node, it still has the issue:

image

My suspicion is that there is something within that Debug addon that is conflicting with the viewfinder overlay, but don't know what that would be. The white overlay is related to the SubViewport node within the ViewfinderPanel control group, as turning that off makes it go away, but the problem goes deeper than that.

Weirder still is that changing the dead zone width or height doesn't work during runtime, but once you remove the debug addon it does. So there are definitely some addon conflicts going on.

@ramokz ramokz changed the title 3d_follow_framed_example_scene.tscn broken Framed Follow viewfinder conflict with debug_draw_3d addon May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants