Skip to content

Commit 2b155f1

Browse files
authored
Upgrade to opencv==4.11.0 (#97)
1 parent 2df0634 commit 2b155f1

File tree

6 files changed

+28
-28
lines changed

6 files changed

+28
-28
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ on:
1717
workflow_dispatch:
1818

1919
env:
20-
MC_CALIB_PROD_DOCKER_IMG: bailool/mc-calib-prod:opencv4100
21-
MC_CALIB_DEV_DOCKER_IMG: bailool/mc-calib-dev:opencv4100
20+
MC_CALIB_PROD_DOCKER_IMG: bailool/mc-calib-prod:opencv4110
21+
MC_CALIB_DEV_DOCKER_IMG: bailool/mc-calib-dev:opencv4110
2222

2323
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
2424
jobs:
@@ -174,7 +174,7 @@ jobs:
174174
./apps/calibrate/calibrate ../tests/configs_for_end2end_tests/calib_param_synth_Scenario1.yml
175175
176176
177-
unit-tests-in-release-mode-opencv4100:
177+
unit-tests-in-release-mode-opencv4110:
178178
runs-on: ubuntu-latest
179179
needs:
180180
- clang-format-lint
@@ -351,7 +351,7 @@ jobs:
351351
python-utils-linters:
352352
runs-on: ubuntu-latest
353353
needs:
354-
- unit-tests-in-release-mode-opencv4100
354+
- unit-tests-in-release-mode-opencv4110
355355
steps:
356356
- name: Checkout
357357
uses: actions/checkout@v2
@@ -371,7 +371,7 @@ jobs:
371371
runs-on: ubuntu-latest
372372
needs:
373373
- python-utils-linters
374-
- unit-tests-in-release-mode-opencv4100
374+
- unit-tests-in-release-mode-opencv4110
375375
steps:
376376
- name: Checkout
377377
uses: actions/checkout@v2

Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ WORKDIR /home
1515
#------------------------------ #
1616
# INSTALL OPENCV 4 #
1717
#------------------------------ #
18-
RUN wget -O opencv.zip https://github.com/opencv/opencv/archive/4.10.0.zip && \
19-
wget -O opencv_contrib.zip https://github.com/opencv/opencv_contrib/archive/4.10.0.zip && \
18+
RUN wget -O opencv.zip https://github.com/opencv/opencv/archive/4.11.0.zip && \
19+
wget -O opencv_contrib.zip https://github.com/opencv/opencv_contrib/archive/4.11.0.zip && \
2020
unzip opencv.zip && unzip opencv_contrib.zip && \
2121
mkdir -p build && cd build && \
22-
cmake -DOPENCV_EXTRA_MODULES_PATH=../opencv_contrib-4.10.0/modules ../opencv-4.10.0 && \
22+
cmake -DOPENCV_EXTRA_MODULES_PATH=../opencv_contrib-4.11.0/modules ../opencv-4.11.0 && \
2323
cmake --build . --target install -- -j4 && \
2424
cd /home && rm opencv.zip && rm opencv_contrib.zip && \
25-
rm -rf opencv-4.10.0 && rm -rf opencv_contrib-4.10.0 && rm -rf build && \
25+
rm -rf opencv-4.11.0 && rm -rf opencv_contrib-4.11.0 && rm -rf build && \
2626
rm -rf /var/lib/apt/lists/*
2727

2828
#------------------------------ #

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ Toolbox described in the paper ["MC-Calib: A generic and robust calibration tool
99

1010
For Windows users, follow [this installation guide](/docs/Windows.md).
1111

12-
Requirements: Ceres, Boost, OpenCV {4.2.0, 4.5.5, 4.10.0}, c++17
12+
Requirements: Ceres, Boost, OpenCV {4.2.0, 4.5.5, 4.10.0, 4.11.0}, c++17
1313

1414
- [Install](https://docs.docker.com/engine/install/) docker
1515

1616
- Pull the image:
1717

1818
```bash
19-
docker pull bailool/mc-calib-prod:opencv4100 # production environment
20-
docker pull bailool/mc-calib-dev:opencv4100 # development environment
19+
docker pull bailool/mc-calib-prod:opencv4110 # production environment
20+
docker pull bailool/mc-calib-dev:opencv4110 # development environment
2121
```
2222

2323
- Run pulled image (set `PATH_TO_REPO_ROOT` and `PATH_TO_DATA` appropriately):
@@ -27,7 +27,7 @@ Requirements: Ceres, Boost, OpenCV {4.2.0, 4.5.5, 4.10.0}, c++17
2727
-ti --rm \
2828
--volume="$PATH_TO_REPO_ROOT:/home/MC-Calib" \
2929
--volume="$PATH_TO_DATA:/home/MC-Calib/data" \
30-
bailool/mc-calib-prod:opencv4100
30+
bailool/mc-calib-prod:opencv4110
3131
```
3232
3333
Compiling the code:

configs/Blender_Images/calib_param_synth_Scenario1.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@ number_y_square_per_board: []
1717
square_size_per_board: []
1818

1919
######################################## Camera Parameters ###################################################
20-
distortion_model: 0 # 0:Brown (perspective) // 1: Kannala (fisheye)
21-
distortion_per_camera : [] # specify the model per camera, #leave "distortion_per_camera" empty [] if they all follow the same model (make sure that the vector is as long as cameras nb)
20+
distortion_model: 0 # 0:Brown (perspective) // 1: Kannala (fisheye)
21+
distortion_per_camera : [] # specify the model per camera, #leave "distortion_per_camera" empty [] if they all follow the same model (make sure that the vector is as long as cameras nb)
2222
number_camera: 2 # number of cameras in the rig to calibrate
2323
refine_corner: 1 # activate or deactivate the corner refinement
24-
min_perc_pts: 0.5 # min percentage of points visible to assume a good detection
24+
min_perc_pts: 0.5 # min percentage of points visible to assume a good detection
2525

26-
cam_params_path: "../data/Blender_Images/Scenario_1/initial_values.yml" # file with cameras intrinsics to initialize the intrinsic, write "None" if no initialization available
27-
fix_intrinsic: 0 #if 1 then the intrinsic parameters will not be estimated nor refined (initial value needed)
26+
cam_params_path: "None" # "../data/Blender_Images/Scenario_1/initial_values.yml" # file with cameras intrinsics to initialize the intrinsic, write "None" if no initialization available
27+
fix_intrinsic: 0 # if 1 then the intrinsic parameters will not be estimated nor refined (initial value needed)
2828

2929
######################################## Images Parameters ###################################################
3030
root_path: "../data/Blender_Images/Scenario_1/Images"
3131
cam_prefix: "Cam_"
32-
keypoints_path: "../data/Blender_Images/Scenario_1/Results/detected_keypoints_data.yml" # "None" #
32+
keypoints_path: "None" # "../data/Blender_Images/Scenario_1/Results/detected_keypoints_data.yml" # "None" #
3333

3434
######################################## Optimization Parameters #############################################
3535
quaternion_averaging: 1 # use Quaternion Averaging or median for average rotation

docs/Windows.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ This documentation is meant to guide the installation of the MC-Calib toolbox, s
2828
Then pull the docker image using either one of the commands given below.
2929

3030
```bash
31-
docker pull bailool/mc-calib-prod:opencv4100 # production environment
32-
docker pull bailool/mc-calib-dev:opencv4100 # development environment
31+
docker pull bailool/mc-calib-prod:opencv4110 # production environment
32+
docker pull bailool/mc-calib-dev:opencv4110 # development environment
3333
```
3434

3535
4. **Running Pulled Image using Docker**
@@ -41,7 +41,7 @@ Docker run `
4141
-ti --rm `
4242
--volume=”$PATH_TO_REPO_ROOT:/home/MC-Calib” `
4343
--volume=”$PATH_TO_DATA:/home/MC-Calib/data” `
44-
bailool/mc-calib-prod:opencv4100
44+
bailool/mc-calib-prod:opencv4110
4545
```
4646

4747
### User Personalization

tests/configs_for_end2end_tests/calib_param_synth_Scenario1.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ number_y_square_per_board: []
1717
square_size_per_board: []
1818

1919
######################################## Camera Parameters ###################################################
20-
distortion_model: 0 # 0:Brown (perspective) // 1: Kannala (fisheye)
21-
distortion_per_camera : [] # specify the model per camera, #leave "distortion_per_camera" empty [] if they all follow the same model (make sure that the vector is as long as cameras nb)
20+
distortion_model: 0 # 0:Brown (perspective) // 1: Kannala (fisheye)
21+
distortion_per_camera : [] # specify the model per camera, #leave "distortion_per_camera" empty [] if they all follow the same model (make sure that the vector is as long as cameras nb)
2222
number_camera: 2 # number of cameras in the rig to calibrate
2323
refine_corner: 1 # activate or deactivate the corner refinement
24-
min_perc_pts: 0.5 # min percentage of points visible to assume a good detection
24+
min_perc_pts: 0.5 # min percentage of points visible to assume a good detection
2525

26-
cam_params_path: "../data/Blender_Images/Scenario_1/initial_values.yml" # file with cameras intrinsics to initialize the intrinsic, write "None" if no initialization available
27-
fix_intrinsic: 0 #if 1 then the intrinsic parameters will not be estimated nor refined (initial value needed)
26+
cam_params_path: "None" # file with cameras intrinsics to initialize the intrinsic, write "None" if no initialization available
27+
fix_intrinsic: 0 # if 1 then the intrinsic parameters will not be estimated nor refined (initial value needed)
2828

2929
######################################## Images Parameters ###################################################
3030
root_path: "../data/Blender_Images/Scenario_1/Images"
@@ -35,7 +35,7 @@ ransac_threshold: 10 # RANSAC threshold in pixel (keep it high just to rem
3535
number_iterations: 1000 # Max number of iterations for the non linear refinement
3636

3737
######################################## Hand-eye method #############################################
38-
he_approach: 0 #0: bootstrapped he technique, 1: traditional he
38+
he_approach: 0 # 0: bootstrapped he technique, 1: traditional he
3939

4040
######################################## Output Parameters ###################################################
4141
save_path: "../data/Blender_Images/Scenario_1/Results"

0 commit comments

Comments
 (0)