Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite Difference Formula Error #6

Open
kgroden opened this issue Jul 10, 2018 · 0 comments
Open

Finite Difference Formula Error #6

kgroden opened this issue Jul 10, 2018 · 0 comments

Comments

@kgroden
Copy link

kgroden commented Jul 10, 2018

I think your finite difference formula that's implemented here may have an error in it (line 351):

ra[m][n] += eps[m][n] * coeffs[j]/step_size * norm * vol/(4.0*pi)

When you're displace coordinates, the displacement is by a normalized, not mass-weighted eigenvector (line 314). You shouldn't need the norm of the vector in this equation, as the total displacement in either direction should simply be "step_size" (you already normalized the displacement effectively). Therefore, that line should be changed to:

ra[m][n] += eps[m][n] * coeffs[j]/step_size * vol/(4.0*pi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant