fix: make faaso CLI exit with error when server returns error

Author: ralsina

TODO.md

@@ -7,7 +7,7 @@
 * A "local run" mode for debugging/development
 * Make proxy start without explicit configuration
 * Get rid of multirun
-* Propagate errors from `run_faaso` to the remote client
+* ✅ Propagate errors from `run_faaso` to the remote client
 * Setting up hostname for Caddy's automatic HTTPS
 * Config UI in frontend?
 * Add multi-container logs to web frontend. It's close but

config/faaso.yml

@@ -2,7 +2,7 @@
 password: adminfoo
 scale:
   builder: 0
-  busqueda: 0
+  busqueda: 2
   foo: 0
   fufu: 0
   historico: 3

src/daemon/funko.cr

@@ -121,7 +121,11 @@ module Funko
 
   post "/rpc/" do |env|
     args = env.params.json["args"].as(Array).map &.to_s
-    run_faaso(args, env)
+    begin
+      run_faaso(args, env)
+    rescue ex : Exception
+      halt env, status_code: 500, response: "Error"
+    end
     Config.reload
     Config.instance.save
   end
@@ -143,7 +147,9 @@ module Funko
         break if process.terminated?
       end
     end
-    # FIXME: find a way to raise an exception on failure
-    # of the faaso process
+    # Because headers are already sent we need to send the
+    # error condition in-band
+    env.response.print("\n##--##--##--##ERROR") if $?.exit_code != 0
+    env.response.flush
   end
 end

src/faaso.cr

@@ -32,13 +32,21 @@ module Faaso
 
   def self.rpc_call(args : Array(String)) : Int32
     user, password = Config.auth
+    buf = IO::Memory.new
     Crest.post(
       "#{Config.server}rpc/",
       {"args" => args},
       user: user, password: password,
       json: true) do |response|
-      IO.copy(response.body_io, STDOUT)
+      IO.copy(response.body_io, buf)
+      buf.seek(0)
+      IO.copy(buf, STDOUT)
+    end
+    if buf.to_s.ends_with? "\n##--##--##--##ERROR"
+      Log.error { "\nServer returned an error" }
+      1
+    else
+      0
     end
-    0
   end
 end