Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add unit / pixel unit for panel size #836

Closed
1 of 2 tasks
thefeymesaleng opened this issue Apr 9, 2024 · 1 comment
Closed
1 of 2 tasks

[Feature]: Add unit / pixel unit for panel size #836

thefeymesaleng opened this issue Apr 9, 2024 · 1 comment

Comments

@thefeymesaleng
Copy link

Describe the feature

It will be convenient to have other units (px etc) supported for sizes (minSize, maxSize etc). Currently it's not clear which unit is supported based on documentation, but I believe it's percentage based.

Other library example:
Take a look at q-splitter by Quasar Framework

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@zernonia
Copy link
Collaborator

Thanks for the suggestion ya @thefeymesaleng . However, we are not planning to support/implement this feature, as implementing pixel-based constraints added significant complexity (quoted by author himself) to the initialization and validation logic.

You can always use resizeObserver to compute the "percentage" yourself 😁

@zernonia zernonia closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants