Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback request: new XSLTs, examples and "diff" tester #6

Open
andybee opened this issue Aug 11, 2017 · 1 comment
Open

Feedback request: new XSLTs, examples and "diff" tester #6

andybee opened this issue Aug 11, 2017 · 1 comment

Comments

@andybee
Copy link
Member

andybee commented Aug 11, 2017

Based on experimentation with the previous XSLT, I've decided to revisit the approach and simplify the documents as much as possible.

There's a new 2.0 branch which includes new version of the XSLT documents, and two example documents. These examples are of an XSI and SI document that should be identical. A diff script now exists in the same /test folder which runs each document through a transform and then diffs the output with the opposing example document.

I'd really appreciate any additional eyes on the two example documents to ensure their validity and that they cover off all the defined element and attributes so that there is then confidence that the passing tests are fair.

Assuming there are no significant bugs in the XSLT or concerns with the approach in this branch, I will merge to master in a few weeks time.

@andybee andybee changed the title New XSLT Feedback request: new XSLTs, examples and "diff" tester Aug 11, 2017
@andybee
Copy link
Member Author

andybee commented Aug 28, 2017

Based on no objections beings reported with the new 2.0 branch, just heads up that I plan to merge it with master and officially tag it as v2.0 in seven days, so if you have interest in this project please do take a moment to review and comment if you can.

The seven day window allows for a grace period on issue #9 which proposes an enhancement I'd like to merge in ahead of release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant