Do not add the package build dir to Info-directory-list by default

[theaimechanic]

Hi! Would it be possible to avoid adding the package build path to the Info-directory-list variable by default?

This is done here

straight.el/straight.el

Line 5190 in af5437f

(defun straight--add-package-to-info-path (recipe)

Most packages do not add info files and having all of them (in a big config) make info lookups slow as hell. Or maybe having a flag to toggle that depending on the package.

If that is not possible, would you recommend to advice straight--add-package-to-info-path to restore a custom list after each call?

Anyways, just a pet peeve, thanks much for your work.

[progfolio]

Good catch. I've noticed slow Info lookups myself, but don't use the system often enough where I looked into it. The fix should be simple enough. I've made it so that only packages which have a dir file in their build directory are added. Old and new behavior demonstrated below with the following test cases:

Old Behavior

(straight-bug-report
  :post-bootstrap 
  (straight-use-package 'org)
  (straight-use-package 'doct)
  (message "Info-directory-list: %S" Info-directory-list))

• Test run at: 2022-06-02 17:45:52
• system-type: gnu/linux
• straight-version: prerelease (HEAD -> fix/info-dir, fork/fix/info-dir) bd89fcf 2022-06-02
• emacs-version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-05-28

Output

Bootstrapping straight.el...
Bootstrapping straight.el...done
Looking for gnu-elpa-mirror recipe → Cloning melpa...
Looking for gnu-elpa-mirror recipe → Cloning melpa...done
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe → Cloning el-get...
Looking for emacsmirror-mirror recipe → Cloning el-get...done
Looking for straight recipe → Cloning emacsmirror-mirror...
Looking for straight recipe → Cloning emacsmirror-mirror...done
Building straight...
Building straight...done

Test run with version: prerelease (HEAD -> develop, origin/develop) 99ba608 2022-05-13
Cloning org...
Cloning org...done
Building org...
Building org...done
Cloning doct...
Cloning doct...done
Building doct...
Building doct...done

Info-directory-list: ("/tmp/straight.el-test-zHXmgA/straight/build/doct/" "/tmp/straight.el-test-zHXmgA/straight/build/org/" "/tmp/straight.el-test-zHXmgA/straight/build/straight/" "/usr/share/info/" "/usr/share/info/" "/usr/share/info/")
Packages:
"straight"                n/a                  develop 99ba608 2022-05-13
"org-elpa"                n/a                  n/a
"melpa"                   n/a                  master 40c73fda 2022-05-31
"gnu-elpa-mirror"         n/a                  master 808923d 2022-05-25
"el-get"                  melpa                master bf3dba44 2022-06-02
"emacsmirror-mirror"      n/a                  master 2e1ceba 2022-06-01
"org"                     org-elpa             main 4197fcc64 2022-06-01
"doct"                    melpa                master 8464809 2022-05-29

New Behavior

(straight-bug-report
  :pre-bootstrap 
  (setq straight-repository-user "progfolio" straight-repository-branch "fix/info-dir")
  :post-bootstrap 
  (straight-use-package 'org)
  (straight-use-package 'doct)
  (message "Info-directory-list: %S" Info-directory-list))

• Test run at: 2022-06-02 17:51:04
• system-type: gnu/linux
• straight-version: prerelease (HEAD -> fix/info-dir, fork/fix/info-dir) bd89fcf 2022-06-02
• emacs-version: GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-05-28

Output

Bootstrapping straight.el...
Bootstrapping straight.el...done
Looking for gnu-elpa-mirror recipe → Cloning melpa...
Looking for gnu-elpa-mirror recipe → Cloning melpa...done
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe → Cloning el-get...
Looking for emacsmirror-mirror recipe → Cloning el-get...done
Looking for straight recipe → Cloning emacsmirror-mirror...
Looking for straight recipe → Cloning emacsmirror-mirror...done
Building straight...
Building straight...done

Test run with version: prerelease (HEAD -> fix/info-dir, origin/fix/info-dir) bd89fcf 2022-06-02
Cloning org...
Cloning org...done
Building org...
Building org...done
Cloning doct...
Cloning doct...done
Building doct...
Building doct...done

Info-directory-list: ("/tmp/straight.el-test-KsCIoO/straight/build/org/" "/usr/share/info/" "/usr/share/info/" "/usr/share/info/")
Packages:
"straight"                n/a                  fix/info-dir bd89fcf 2022-06-02
"org-elpa"                n/a                  n/a
"melpa"                   n/a                  master 40c73fda 2022-05-31
"gnu-elpa-mirror"         n/a                  master 808923d 2022-05-25
"el-get"                  melpa                master bf3dba44 2022-06-02
"emacsmirror-mirror"      n/a                  master 2e1ceba 2022-06-01
"org"                     org-elpa             main 4197fcc64 2022-06-01
"doct"                    melpa                master 8464809 2022-05-29

[progfolio]

@Artistu I've merged the change into the "develop" branch. Testing is appreciated.

[theaimechanic]

Tested, works as expected @progfolio . I appreciate the quick turnaround, many thanks!