Rework type guards in Radashi #46
aleclarson
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
For return types radashi could also profit from https://github.com/sindresorhus/type-fest. |
Beta Was this translation helpful? Give feedback.
1 reply
-
Just to keep trace:
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
There are libraries like
@sindresorhus/is
out there that are more widely used, which are therefore more battle-tested/robust and (perhaps most importantly) more comprehensive.I suggest copying my code from https://github.com/alloc/is/blob/master/src/is.ts (which is written to be tree-shakeable and not rely on NodeJS types anywhere). Then we can update its implementation to align with
@sindresorhus/is
to achieve the same robustness without the baggage.Related issues
Beta Was this translation helpful? Give feedback.
All reactions