WIP: Collection interfaces with mutableSublist producing a write through view #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very rough draft of a generic collection API for Rhombus.
the sublist method on MutableList now produces unmodifiable read-through views
AlexKnauth
force-pushed
the
collections-write-through-view-2
branch
from
e8574f7
to
55da26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated version of #259, rebased onto #329 to fix an issue that came up while working on it, with some of the ideas from the
mutableSublistdiscussion implemented into it.From a discord discussion on 2023-05-03:
ListView,StringView, etc. into a discussion aboutsublistand copies vs. unmodifiable read-through views vs. write-thorugh views around here: https://discord.com/channels/571040468092321801/871953739982995547/1103365932753113149sublistmethod to produce an unmodifiable read-through view while a separate methodmutableSublistproduces a write-thorugh view was first brought up here: https://discord.com/channels/571040468092321801/871953739982995547/1103395023845855293