Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should virtual host-specific definition import exclude virtual host name? #10078

Open
michaelklishin opened this issue Dec 8, 2023 · 0 comments
Assignees

Comments

@michaelklishin
Copy link
Member

See #10068 for the background.

During that investigation we have learnt that in early 2016 in 8ba0e07 a decision was to exclude the vhost field when exporting definitions of a single virtual host. I don't remember the details but the goal
could have been to allow for such files to be imported into any virtual host in a different cluster.

We can restore the vhost field to avoid the confusing scenario in #10068 and possibly ignore it during the import operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants