Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading DBI a second time breaks dbConnect(RSQLite::SQLite()) #247

Open
krlmlr opened this issue Jun 19, 2023 · 0 comments
Open

Loading DBI a second time breaks dbConnect(RSQLite::SQLite()) #247

krlmlr opened this issue Jun 19, 2023 · 0 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Jun 19, 2023

I need a manual unloadNamespace(), before or after the second load_all(), to be actually able to use it. Should we unload all dependent namespaces when load_all() is reloading?

gert::git_clone("https://github.com/r-dbi/DBI")

pkgload::load_all("DBI")
#> ℹ Loading DBI
con <- dbConnect(RSQLite::SQLite(), ":memory:")
dbDisconnect(con)
rm(con)

# unloadNamespace("RSQLite")

pkgload::load_all("DBI")
#> ℹ Loading DBI
dbConnect(RSQLite::SQLite(), ":memory:")
#> Error in (function (classes, fdef, mtable) : unable to find an inherited method for function 'dbConnect' for signature '"SQLiteDriver"'

Created on 2023-06-19 with reprex v2.0.2
krlmlr added a commit to r-dbi/DBI that referenced this issue Jun 19, 2023
@krlmlr
chore: Fix lazytest, upstream: r-lib/pkgload#247
31acc92
clrpackages pushed a commit to clearlinux-pkgs/R-DBI that referenced this issue Dec 22, 2023
@fenrus75 @clrpackages
R-DBI: Autospec creation for update from version 1.1.3 to version 1.2.0
796e725 
Hadley Wickham (6):
      Correct vignette titles
      use_testthat(3)
      Remove requirement to name ID components
      Move dbQuoteIdentifer implementation
      A more general strategy for unquoting
      A more general strategy for unquoting

Indrajeet Patil (8):
      use devel pak
      Use R-CMD-check-base to avoid flood of PRs
      add newline at the end
      Harmonize yaml formatting (#20)
      remove rmarkdown bandaid; closes #24
      fixes dev workflow
      Workaround for bug in `setup-r-dependencies` (#32)
      Use v2 release of `setup-r-dependencies`

Kirill Müller (115):
      Bump version to 1.1.3.9000
      docs: Tweak typo, add families for data retrieval and command execution
      Update maintainer e-mail
      Move declaration
      Work around roxygen2 buglet
      Avoid registering classes we don't own
      Avoid double and triple dispatch
      Comment
      Document
      Add test
      Use custom data
      Avoid double dispatch
      Tweak test
      Link to issue
      New vignette
      Bump version to 1.1.3.9001
      Enable BLOB tests
      Define default data type for blob and arrow_binary
      dbSendQueryArrow() -> dbSendQueryStream()
      ResultArrow|ArrowResult -> ResultStream
      dbCreateFromStream() and dbAppendStream()
      Appending data
      Support Arrow in dbBind()
      Add dbBind() example
      Add vctrs
      stats::
      Rename test
      Bump version to 1.1.3.9002
      Avoid auto-styling Rmd files for now
      feat: Implement `dbiDataType()` for objects of class `"blob"`
      feat: `dbWriteStream()` returns invisibly
      feat: `dbAppendStream()` silences warnings about converting factors to character
      Bump version to 1.1.3.9003
      Oops
      Careful
      Checkout v2 -> v3
      Document
      Harmonize table documentation
      Tweak vignette
      Fix MariaDB version on GHA
      Require recent version of Arrow
      Document
      Replace in code
      Rename
      Document
      Bump version to 1.1.3.9004
      Add workflow_dispatch
      Retry deployment
      Require recent version of arrow for examples
      Adapt condition
      Set vars after instaling R
      Remove unused
      Better styler safety
      Better covr packages
      Better snapshot PRs
      Upgrade to Ubuntu 22.04
      Use GITHUB_OUTPUT
      Use GITHUB_OUTPUT correctly
      Add fledge workflow
      Avoid multiarch
      Install only fledge for fledge workflow
      Tweak fledge workflow
      Add release check
      Concurrency tweaks
      chore: Fix lazytest, upstream: r-lib/pkgload#247
      fix: Don't collate zzz.R
      fix: Avoid collate altogether
      Switch to nanoarrow
      More rows
      Avoid arrow reference
      Try dev nanoarrow
      Install from URL, r-lib/pak#508
      Only unload if loaded
      For real
      Stricter
      chore: Install nanoarrow from CRAN
      Renovate fledge
      Renovate, check without suggested packages, parallel and ccache
      Use own ccache-action, clean up
      Remove validation workflow
      chore: Add Aviator configuration
      Add missing dbDisconnect()
      test: Fix checks without suggested packages
      Clarify type
      docs: Deal with sundown of <https://relational.fit.cvut.cz>
      feat: New `dbFetchArrowChunk()` generic with different semantics
      Mention in docs
      Use nanoarrow::basic_array_stream()
      Avoid deferred evaluation
      feat: New `dbIsValid()` method for `"DBIResultArrowDefault"` objects implemented by DBI
      docs: Clarify repeated parameter binding
      test: Run DBItest for SQLite package as part of the checks here
      Require nanoarrow
      chore: Test with dev version of DBItest
      chore: Rename files
      Better default dbFetchArrow()
      fix: Return original result set invisibly from `dbBind()`
      chore: `dbBind()` for `DBIResultArrow` passes `params` as is
      Add dbBindArrow() generic and default implementations
      Join docs
      Bump version to 1.1.99.9000
      chore: `dbUnquoteIdentifier()` fails with character vectors containing `NA`
      Bump version to 1.1.99.9001
      Bump version to 1.2.0
      CRAN comments
      Fix URLs
      _R_CHECK_UNDOC_USE_ALL_NAMES_
      Document object
      Un-backtick
      Remove remote
      revdepcheck results
      NEWS and CRAN comments [ci skip]
      CRAN comments
      Recognize Id(column = )
      Back to the auto-check train

Maëlle Salmon (4):
      docs: update template
      fix colors
      experiment with wavy underline on hover so as not to change color on hover (since the color then has a bad contrast)
      don't change navbar link color on hovering

Nicolas Bennett (19):
      test drive arrow
      try consuming arrow
      fix class name
      fix examples
      add dbFetchArrow()
      add dbSendQueryArrow()
      use dbGetQueryArrow() in dbReadTableArrow()
      add docs comments
      add dbBind() for DBIArrowResult
      add dbGetInfo() et al for DBIArrowResult
      add dbStream()
      add dbGetStream()
      rename dbReadTableArrow() -> dbStreamTable()
      rm row.names from dbStreamTable()
      add dbWriteStream()
      add small arrow roundtrip test
      fix setClass()
      revert dbFetch() to always return data.frame
      improve naming of arrow result objects

eauleaf (6):
      Produce the DB indexing parameters in SQL order.
      simplify doc changes
      simplified code
      updated per krlmlr and hadley comments
      to minimize changes
      Update R/00-Id.R

hadley (2):
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions

krlmlr (31):
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9005
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9006
      Bump version to 1.1.3.9007
      Bump version to 1.1.3.9008
      Bump version to 1.1.3.9009
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9010
      Bump version to 1.1.3.9011
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9012
      Bump version to 1.1.3.9013
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9014
      Bump version to 1.1.3.9015
      Bump version to 1.1.3.9016
      Auto-update from GitHub Actions
      Bump version to 1.1.3.9017
      Auto-update from GitHub Actions
      Auto-update from GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlmlr