-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function to analyze history branch/data #50
Comments
I think it's definitely interesting to have this code somewhere. But I'm not 100% sure where. We have been talking with @maelle about changing the location of the historical data. Possibly to a separate repo. If this happens, then I think your code would be better there than in the main repo(?). Not sure... What do you think? |
Currently it is on some file of my code for some presentations so it is public (but probably hard to find :) Yes, she mentioned something on #36 (comment). Currently with this code I haven't found a problem dealing with these many files, the code I previously used was highly inefficient (ultimately too many files might become a problem, but I'm not sure of the OS limits or R limits on this). |
A package to consult historical data could be called {cransaid} 😁 If the data were in a separate repo shouldn't the package be in a third repo? |
If the data is in a different repo there is really a need for a new package? To split the functionality between recording data {cransays}, storing data {cranwas} and analyzing data {cransaid}? |
I thought this over again and I think it actually makes sense to have the function to load the historical data inside cransays. I think having a short analysis of historical data on the cransays website would be useful to give users of the dashboard an idea of a typical path and what they can expect for their submission. In particular, we could partially address #29 and #40 by dynamically generating a flow diagram with igraph based on historical data. |
Note that the #40 archive directory not showing up was not solved. Update of packages already on CRAN are sometimes very fast (<15 minutes) so they aren't captured by the dashboard. I will create a PR with the code I used to get together all the files (maybe I'll need to modify it to be able to parse the new column recently added). There is also a .R file on the history branch https://github.com/r-hub/cransays/blob/history/analysis.R |
I know cransays is not really to deliver code, but I have some code to merge all the csv files of the history branch that I think it would be helpful to others (and myself) if it were documented here.
The code solves merging some files with different headers efficiently (previous iterations of the code lasted 30 minutes and now I can do it in just 1).
I think it doesn't have dependencies and wouldn't need to be run or tested but it could help others if they want to analyze the data.
Let me know if it would be helpful/appropriate and I would create a PR with the code.
The text was updated successfully, but these errors were encountered: