Ocrd cli

[kba]

No description provided.

[bertsky]

Far from a deep understanding, but some things should be improved even in the first version I believe.

@vahidrezanezhad, please have a look whether my suggestions for the ocrd-tool parameter descriptions are correct.

@kba, please consider the common case where meta-data is present but has no DPI, and if it's not too late (or too much), try to improve the general (image/PAGE) data passing interface.

[kba]

eynollah itself doesn't work with the page.imageFilename, so I don't see a reason to changing it.

yes it does: you pass it as image_filename kwarg below, which then gets opened with cv2.imread.

oh right, my bad, will change it to pass it the return of download_file.

Since we're encouraging METS-relative paths, there might be mets:files that are URL but I can't think of a scenario where pc:Page/@imageFilename would be a URL (except in our test data).

granted, but then why use mets.find_files(url=page.imageFilename) here at all?

Mostly because I want to make sure that the PAGGE @imageFilename is in the METS. If it isn't this will raise an IterationError.

[bertsky]

It all makes sense to me now (but have not tested).