Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock on Top of Page #631

Open
jadshaker opened this issue Feb 21, 2024 · 6 comments
Open

Clock on Top of Page #631

jadshaker opened this issue Feb 21, 2024 · 6 comments

Comments

@jadshaker
Copy link

While reading quraan from the app, it would be beneficial to be able to view the clock in the top middle of the page.

@mohamede1945
Copy link
Collaborator

Thank you for submitting the feature request. Currently, by tapping on the page, the system clock will appear, and tapping again will hide it. I am cautious about adding a permanent clock display, as it may distract from the reading experience. Additionally, this behavior aligns with other reading apps, such as Apple's Books app, making it intuitive for users.

@jadshaker
Copy link
Author

Thank you for your response, but when you read in landscape it doesn't show. It happened when we were praying qiyam and we wanted to know how much time left till fajr, so we thought it would be a good idea to implement it. Thank you!

On a side note, how can someone contribute to the community?

@mohamede1945
Copy link
Collaborator

Oh I see. It's a best practice in iOS to hide the system clock on iPhones when in landscape mode (see almost all iOS apps that supports landscape). While I acknowledge your concern, I'm currently uncertain about the best approach to address it.

@mohamede1945
Copy link
Collaborator

Regarding contributions, the app is now open source, allowing you to contribute by fixing bugs or adding new features. However, please inform us before starting any work by adding a comment to an existing issue or opening a new one if none exists.

@wedkemail
Copy link

Hey @mohamede1945 shall i give this a go?

@mohamede1945
Copy link
Collaborator

I'm still not sure the best approach to address this. I don't want to deviate from a standard iOS pattern of hiding the clock on landscape mode.

Feel free to suggest some ideas. And let me know if you want to contribute, I can guide you to other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants