Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending a tail-loss probe a PING frame can be added to a DATAGRAM frame #2173

Open
flub opened this issue Mar 17, 2025 · 0 comments
Open

Comments

@flub
Copy link
Contributor

flub commented Mar 17, 2025

When a tail-loss probe needs to be sent the current queue_probe algorithm adds a PING frame even if a DATAGRAM frame could also be sent. This wastes a single byte, potentially amplified by being the start of a GSO batch.

This isn't that bad, there are many cases in which the user datagram would not fit into the probe packet anyway. Still, it could be a nice small improvement.

See #2169 which tried to solve this before, but probably broke some edge cases: https://github.com/quinn-rs/quinn/pull/2169/files#r1987103861

See #2172 which reverts this part of #2169 again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant