-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Denotation char span in blot is being flattened by setting innerText #357
Comments
I'd be in favor of putting back the previous HTML structure with a minor version, but it might not be necessary due to the major version being upgraded. |
@crabmusket / @csculley Any update so far over above issue I'm also facing this issue. We are dynamically replacing placeholder with class="ql-mention-denotation-char" name but now it's not coming in latest version. |
@rupeshdeotale97 Can you make a new Q&A question for that issue with more information here? You should have full access to how list items and mention blot nodes are displayed. The docs webpage also has an example of overriding the mention item however you'd like which might be helpful here |
Currently, the MentionBlot adds the value using
innerText
:quill-mention/src/blots/mention.js
Line 26 in f2801f2
Previously, this was
innerHTML
:quill-mention/src/blots/mention.js
Line 21 in 312704e
I assume this change was made for safety reasons. However, this means the resulting HTML has changed from
To
This isn't the end of the world, but I think it'd be nice to maintain existing behaviour. I suspect the solution is something like:
I'm happy to PR this if you agree! Otherwise it might be worth noting this in the readme for others upgrading from 3.x
The text was updated successfully, but these errors were encountered: