-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Quilt RFC #45
Comments
Just a comment here -- working on a PR that addresses some of the other points
|
Another: an example of
This example, which invokes a waveform as part of an expression:
|
Related to rigetti/pyquil#1257, which will by default serve as the reference implementation of Quilt.
Mismatches between RFC and implemented grammar:
OpModifier
used in place ofGateModifier
:CalibrationDefinition :: DEFCAL OpModifier* Name ( Parameter+ ) Qubit+ : Instruction+
SetPhase :: SET-PHASE Frame Float
should beSetPhase :: SET-PHASE Frame Expression
to match grammarDEFCAL MEASURE
shows aName
:MeasureCalibrationDefinition :: DEFCAL Name Qubit? Parameter : Instruction+
, but the example doesn't match that spec:DEFCAL MEASURE 0 %dest:
, and the implemented grammar isdefMeasCalibration : DEFCAL MEASURE qubitOrFormal ( name )? COLON ( NEWLINE TAB instr )* ;
which disagrees with both (example shows avariable
notname
)Doc Improvements & Bugfixes:
DEFFRAME
exampleCAPTURE
keyword:CAPTURE 0 "out" 200e-6 iqs
MEASURE
There is also support for shifted the phase
DEFFRAME
?CENTER-FREQUENCY
missing in spec but present in grammarLT
instruction in example not described in spec (here or in main spec):LT %dest iq[0] 0.5 # thresholding
Spec improvements:
DELAY
grammar is the only item which requires left recursion, because the requiredexpression
could match as anidentifier
. Is that worth reconsideration?DEFCIRCUIT
includesCircuitGate
s within its instruction block, which is the version ofGate
with variable qubits.DELAY
andFENCE
, though, just allow variable qubits in the base instruction instead of a distinctCircuitDelay
orCalibrationDelay
. Is it worth reconsideration ofCircuitGate
to collapse it withGate
for consistency?The text was updated successfully, but these errors were encountered: