Skip to content

updater/driver: add the ability to signal "removal" in an update - #1179

Open
hdonnay wants to merge 1 commit into
quay:mainfrom
hdonnay:hack/new-updater/delta
Open

updater/driver: add the ability to signal "removal" in an update#1179
hdonnay wants to merge 1 commit into
quay:mainfrom
hdonnay:hack/new-updater/delta

Conversation

@hdonnay

@hdonnay hdonnay commented Dec 13, 2023

Copy link
Copy Markdown
Member

No description provided.

@hdonnay
hdonnay requested a review from a team as a code owner December 13, 2023 22:08
@hdonnay
hdonnay requested review from crozzy and removed request for a team December 13, 2023 22:08
@codecov

codecov Bot commented Dec 13, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.82%. Comparing base (ffcb29e) to head (4fb218e).
⚠️ Report is 601 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   55.86%   55.82%   -0.05%     
==========================================
  Files         266      266              
  Lines       16625    16625              
==========================================
- Hits         9288     9281       -7     
- Misses       6374     6379       +5     
- Partials      963      965       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Repository []Repository
// Removed is a list of Vulnerabilities (the "Name" member) removed in the
// current set of Vulnerabilities.
Removed []string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention: I had the realization that for us the Name is generic i.e. for some VEX CVE files we generate 100s of vulnerabilities with the same name (CVE-2023-001 for samba, CVE-2023-001 for samba-libs etc). This didn't actually change much except that the UpdateVulnerabilities() method now parses existing vulnerabilities into a map[string][]string, where the key is the name (CVE-2023-001) and the value is a list of all vuln ID that share that name.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that to say, I think this is still valid, it's just worth pointing out the nuanced difference

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right -- this isn't in use yet, but I imagine this is in the current Updater's namespace

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
hdonnay force-pushed the hack/new-updater/delta branch from 6956336 to 4fb218e Compare March 27, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants