Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make load and error an event? #7

Open
mesqueeb opened this issue Jul 29, 2019 · 9 comments
Open

make load and error an event? #7

mesqueeb opened this issue Jul 29, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@mesqueeb
Copy link
Contributor

Hi! Thanks for this!!

I was just wondering instead of

<q-pdfviewer
      :value="true"
      :src="src"
      :error="onError"
      :load="onLoad"
      content-class="fit _container"
      inner-content-class="fit _container"
    />

isn't it more natural to have error and load be events like so:

    <q-pdfviewer
      :value="true"
      :src="src"
      @error="onError"
      @load="onLoad"
      content-class="fit _container"
      inner-content-class="fit _container"
    />
@hawkeye64
Copy link
Member

Yes. That being said, I will be investigating PDF.js so things may change. What this will give us is:

  1. Ability to display PDF on browsers (and version) that doen't support embedded PDF
  2. Ability to display PDF in am Electron app

@rrigaud
Copy link

rrigaud commented Aug 5, 2019

Yes. That being said, I will be investigating PDF.js so things may change. What this will give us is:

  1. Ability to display PDF in am Electron app

Does that mean today, this extension doesn't work with Electron App ?
Because I fail using it...
Cannot GET /Users/raph/Library/Application%20Support/DroopyTempCut/file_1.pdf

I can't preview any PDF, with local or distant URL... It seems that the URL isn't good, the console said :

GET http://localhost:8080/Users/raph/Library/Application%20Support/DroopyTempCut/file_1.pdf 404 (Not Found)

Sorry for my english, but I was so excited about using this Quasar Extension, it's a really important to me to be able to preview a PDF file inside my App...

Thanks a lot for your work.

@yelena870513
Copy link

Yes. That being said, I will be investigating PDF.js so things may change. What this will give us is:

  1. Ability to display PDF in am Electron app

Does that mean today, this extension doesn't work with Electron App ?
Because I fail using it...
Cannot GET /Users/raph/Library/Application%20Support/DroopyTempCut/file_1.pdf

I can't preview any PDF, with local or distant URL... It seems that the URL isn't good, the console said :

GET http://localhost:8080/Users/raph/Library/Application%20Support/DroopyTempCut/file_1.pdf 404 (Not Found)

Sorry for my english, but I was so excited about using this Quasar Extension, it's a really important to me to be able to preview a PDF file inside my App...

Thanks a lot for your work.

Facing the same issue when displaying on electron

@hawkeye64
Copy link
Member

I am working hard to get a lot of the app-exts converted to Quasar v2. It's on the list, but this one is difficult because of PDFjs being such a pain to work with. I can't say for sure when it'll be done.

@hawkeye64
Copy link
Member

#87

@CynthiaBlue
Copy link

I've just installed app-extension-qpdfviewer and am trying it out on my electron/quasar application. Following the examples, I'm getting a file not found error. Is my problem the same as this thread... so I cannot use it at this time? I'm running Quasar version 3.3.3 and Electron version 16.07.


<q-pdfviewer
          type="pdfjs"
          :src="src"
        />
...
 src: '/pdf/pdf-test.pdf'

Screen Shot 2022-03-28 at 1 47 24 PM

@hawkeye64
Copy link
Member

Does it work when not running Electron mode?

@CynthiaBlue
Copy link

I haven't tried it. My desktop app requires electron.

@hawkeye64
Copy link
Member

I'll try with Electron in the coming days.

@nucle nucle added the enhancement New feature or request label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants