-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add pseudo monitoring option 'none' to disable all monitoring options #48872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview cbc2cde has been successfully built and deployed to https://quarkus-pr-main-48872-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
I'll let @galderz review this |
OK, thanks. He'll be back Friday. |
👌🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jerboaa. I think adding the option makes sense. Just a small comment to make the code clearer.
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
83d1e4a
to
6395243
Compare
A test with
A test with
And finally, a test without any
|
This option isn't regognized by native-image, but it's a way to disable all monitoring options that quarkus would otherwise add without that setting. Related: quarkusio#46890
6395243
to
39deefc
Compare
Status for workflow
|
Status for workflow
|
This option isn't recognized by
native-image
, but it's a way to disable all monitoring optionsthat quarkus would otherwise add without that setting. For example,
--enable-monitoring=heapdump
isadded by default without the user doing anything for native builds. This patch doesn't change this behaviour,
but adds an option to turn it off by specifying
-Dquarkus.native.monitoring=none
It would be a step to make some progress on #46890 since we aren't sure if the
heapdump
monitoring option is causing it. If it is, we'd know more.Thoughts?
Related: #46890