Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV InstallMode is not correct by default and should take namespaces information into account #839

Open
metacosm opened this issue Mar 4, 2024 · 0 comments · May be fixed by #841
Open

CSV InstallMode is not correct by default and should take namespaces information into account #839

metacosm opened this issue Mar 4, 2024 · 0 comments · May be fixed by #841
Assignees
@metacosm

Comments

@metacosm
Copy link
Member

metacosm commented Mar 4, 2024

Right now, the install mode is only changed if CSVMetadata is provided and defaults to AllNamespaces, which isn't correct.
@metacosm metacosm self-assigned this Mar 4, 2024
metacosm added a commit that referenced this issue Mar 4, 2024
@metacosm
fix: add proper default install mode derived from watched namespaces
415d6b2 
Fixes #839

Signed-off-by: Chris Laprun <[email protected]>
@metacosm metacosm linked a pull request Mar 4, 2024 that will close this issue
Open
metacosm added a commit that referenced this issue Mar 5, 2024
@metacosm
fix: add proper default install mode derived from watched namespaces
35df666 
Fixes #839

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Mar 7, 2024
@metacosm
fix: add proper default install mode derived from watched namespaces
f45b978 
Fixes #839

Signed-off-by: Chris Laprun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@metacosm