Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling widget.dispose() doesn't remove the widget from the layout parent. #10507

Open
lucapivato opened this issue Dec 20, 2022 · 2 comments
Open

Calling widget.dispose() doesn't remove the widget from the layout parent. #10507

lucapivato opened this issue Dec 20, 2022 · 2 comments

Comments

@lucapivato
Copy link
Contributor

Not sure if this is a bug or the intended behavior. I'm going to change it in our branch.

In the destroy method in qx.ui.core.Widget it checks if the widget is already disposed and exists if it is. However, calling dispose() on a widget it sets the this.$$disposed flag to true and then calls the destructors second, and since parent_remove(this) in Widget.destroy() comes after the $$disposed check calling dispose() leaves disposed widget as invalid children.

Calling destroy() on the widget remove it but queues the disposal(). It seems to me that it would be more consistent to remove the widget from the layout parent also if calling dispose().
@hkollmann
Copy link
Member

Could you create a PR please?

lucapivato added a commit that referenced this issue Dec 20, 2022
@lucapivato
Fix for #10507
00f2d84
@lucapivato
Copy link
Contributor Author

Looks like the Destroy test doesn't like it.

BTW this is a repro simple case: https://tinyurl.com/bdcss7db

hkollmann pushed a commit that referenced this issue Feb 15, 2023
@lucapivato @oetiker
Fix for #10507 (#10508)
a88f1e7 
Co-authored-by: Tobias Oetiker <[email protected]>
hkollmann added a commit that referenced this issue Feb 15, 2023
@hkollmann
Revert "Fix for #10507 (#10508)"
3955c01 
This reverts commit a88f1e7.

This was unintentional, sorry!
johnspackman added a commit to johnspackman/qooxdoo that referenced this issue Feb 21, 2023
@johnspackman
Merge branch 'unified-webfonts'
685b6d5 
* unified-webfonts: (43 commits)
  fixes qooxdoo#10494
  Fix two images in scaled basic.Image (qooxdoo#10540)
  Add special background for IndigoDark menu button (qooxdoo#10538)
  qx es6ify --git-pre-commit kills format. Changed comment to // so qx es6ify --git-pre-commit works correct
  lint again
  fix lint
  fix lint issue
  Revert "Fix for qooxdoo#10507 (qooxdoo#10508)"
  Fix for qooxdoo#10507 (qooxdoo#10508)
  Bump http-cache-semantics from 4.1.0 to 4.1.1 in /known-good (qooxdoo#10533)
  Bump cacheable-request and update-notifier (qooxdoo#10537)
  Added check for case when value of static method is reference to another class method (qooxdoo#10534)
  Remove obsolete parts and edit desktop (qooxdoo#10530)
  Catch block for no xml file for locale (qooxdoo#10531)
  Edit desktop docs (qooxdoo#10524)
  Fixes for locale bugs  (qooxdoo#10527)
  Fixed sass warning for mobile resources (qooxdoo#10528)
  Templates from es5 to es6 syntax (qooxdoo#10526)
  Grammar and reference fixes (qooxdoo#10525)
  "Release v7.5.0"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hkollmann @lucapivato