Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

defaultTarget should not be restricted to "source" or "build" #723

Open
cboulanger opened this issue Jun 17, 2020 · 2 comments
Open

defaultTarget should not be restricted to "source" or "build" #723

cboulanger opened this issue Jun 17, 2020 · 2 comments

Comments

@cboulanger
Copy link
Contributor

Currently, the defaultTarget key of compile.json can only be "source" or "build".

I propose to remove that restriction, any target should be be able to be set as default.

@johnspackman
Copy link
Member

that won't work - defaultTarget would be better named defaultTargetType (and so would --target argument), so the target types can only be "source" or "build" because that is the only two that there is code for.

EG if you have one "source" target which has "application-types": ["browser"], "outputPath": "compiled/source" and a second "source" which has "application-types": ["node"], "outputPath": "compiled/source-node"

They are both "source" targets and both compiled.

If you want to only compile one target, then you need to only compile the applications that use that target. EG if you have an application which has "name": "myApp", "application-type": "browser", you can do qx compile --app-name=myApp - this will only compile into compiled/source.

@cboulanger
Copy link
Contributor Author

Ok, thanks, I did not know. I'll leave the issue open for the time being, in case others stumble upon the same question or we revisit the issue, but postpone the issue until later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants