From efe6185610870ee1fda49594d5685a2ad1783452 Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 4 Feb 2019 17:05:17 +0100 Subject: [PATCH] Fix update_event_internal_probas out-of-bounds access --- igor_src/Dinuclmarkov.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/igor_src/Dinuclmarkov.cpp b/igor_src/Dinuclmarkov.cpp index d1416d6..3a9093c 100644 --- a/igor_src/Dinuclmarkov.cpp +++ b/igor_src/Dinuclmarkov.cpp @@ -476,8 +476,7 @@ void Dinucl_markov::update_event_internal_probas(const Marginal_array_p& margina for(Int_nt prev_nt: previous_list){ for(Int_nt next_nt : next_list){ - this->dinuc_proba_matrix(i,j) += marginal_array[event_index + i*event_realizations.size() + j]; - //TODO This is risky in case teh code evolves to ahve more than realizations + this->dinuc_proba_matrix(i,j) += marginal_array[event_index + prev_nt*event_realizations.size() + next_nt]; } } //By taking the average we assume all nucleotides underlying the ambiguous one are equally probable