Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason for save_best_model not to be a parameter of VisionClassifierTrainer? #47

Open
RicoFio opened this issue May 11, 2024 · 0 comments
Open

Any reason for save_best_model not to be a parameter of VisionClassifierTrainer? #47

RicoFio opened this issue May 11, 2024 · 0 comments

Comments

@RicoFio
Copy link

RicoFio commented May 11, 2024

Currently, for TorchVisionClassifierTrainer, save_best_model is an initialization parameter of the class. However, that's not the case for the VisionClassifierTrainer and it's set to False. Is there a specific reason for this discrepancy or can this be updated?

HugsVision/hugsvision/nnet/VisionClassifierTrainer.py

Line 91 in 476507a

load_best_model_at_end = False,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RicoFio