Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest FBGEMM doesn't build with latest PyTorch #2318

Open
ezyang opened this issue Feb 7, 2024 · 1 comment · May be fixed by #2319
Open

Latest FBGEMM doesn't build with latest PyTorch #2318

ezyang opened this issue Feb 7, 2024 · 1 comment · May be fixed by #2319

Comments

@ezyang
Copy link
Contributor

ezyang commented Feb 7, 2024

Failure:

FAILED: CMakeFiles/fbgemm_gpu_py.dir/src/sparse_ops/sparse_ops_cpu.cpp.o                                                           /usr/bin/c++ -DUSE_C10D_GLOO -DUSE_C10D_NCCL -DUSE_DISTRIBUTED -DUSE_RPC -DUSE_TENSORPIPE -Dfbgemm_gpu_py_EXPORTS -I/data/users/ezy
ang/b/FBGEMM/fbgemm_gpu -I/data/users/ezyang/b/FBGEMM/fbgemm_gpu/include -I/data/users/ezyang/b/FBGEMM/fbgemm_gpu/../include -I/dat
a/users/ezyang/b/FBGEMM/fbgemm_gpu/../third_party/asmjit/src -I/data/users/ezyang/b/FBGEMM/fbgemm_gpu/../third_party/cpuinfo/includ
e -isystem /data/users/ezyang/b/pytorch/torch/include -isystem /data/users/ezyang/b/pytorch/torch/include/torch/csrc/api/include -i
system /usr/local/cuda-12.0/include -D_GLIBCXX_USE_CXX11_ABI=1 -O3 -DNDEBUG -std=c++17 -fPIC -D_GLIBCXX_USE_CXX11_ABI=1 -mavx -mf16
c -mfma -mavx2 -fopenmp -MD -MT CMakeFiles/fbgemm_gpu_py.dir/src/sparse_ops/sparse_ops_cpu.cpp.o -MF CMakeFiles/fbgemm_gpu_py.dir/s
rc/sparse_ops/sparse_ops_cpu.cpp.o.d -o CMakeFiles/fbgemm_gpu_py.dir/src/sparse_ops/sparse_ops_cpu.cpp.o -c /data/users/ezyang/b/FB
GEMM/fbgemm_gpu/src/sparse_ops/sparse_ops_cpu.cpp                                                                                  
/data/users/ezyang/b/FBGEMM/fbgemm_gpu/src/sparse_ops/sparse_ops_cpu.cpp: In function ‘Tensor fbgemm_gpu::native_empty_like(const T
ensor&)’:                                                                                                                          
/data/users/ezyang/b/FBGEMM/fbgemm_gpu/src/sparse_ops/sparse_ops_cpu.cpp:131:7: error: ‘optTypeMetaToScalarType’ was not declared i
n this scope; did you mean ‘c10::optTypeMetaToScalarType’?                                                                         
  131 |       optTypeMetaToScalarType(self.options().dtype_opt()),                                        
      |       ^~~~~~~~~~~~~~~~~~~~~~~                                                                                              
      |       c10::optTypeMetaToScalarType 
@ezyang ezyang linked a pull request Feb 7, 2024 that will close this issue
@q10
Copy link
Contributor

q10 commented Feb 7, 2024

This is similar to pytorch/pytorch#115623, but fbgemm appears to already have the fix:

c10::optTypeMetaToScalarType(self.options().dtype_opt()),

Are you using an older version of fbgemm_gpu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants