Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate scroll-offset management issues on pages with sticky banner #3065

Open
pradyunsg opened this issue Mar 20, 2023 · 1 comment · May be fixed by #3066
Open

Investigate scroll-offset management issues on pages with sticky banner #3065

pradyunsg opened this issue Mar 20, 2023 · 1 comment · May be fixed by #3066
Assignees
Labels
infra Core infrastructure for building and rendering PEPs

Comments

@pradyunsg
Copy link
Member

In testing this, sometimes when loading a page with a fragment identifier (the original scenario motivating this change), at least for me in FF on Windows, the scroll offset isn't applied and the banner covers the heading, which I'm guessing is because the scroll event races this snippit on DOMContentLoaded and sometimes the scroll is executed before the scroll offset has been set.

Originally posted by @CAM-Gerlach in #2992 (review)

Decided to defer the detailed investigation into this for a follow-up change -- this is an issue for tracking either the change of issuing an additional scroll event or using a different mechanism (eg: something render-blocking) to set the scroll offset instead or some other way to avoid the occasional race condition.

@pradyunsg pradyunsg added the infra Core infrastructure for building and rendering PEPs label Mar 20, 2023
@pradyunsg
Copy link
Member Author

FWIW, I've not been able to reproduce this personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@pradyunsg and others