Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network issues are hidden by the install script #122

Open
13steinj opened this issue Jul 15, 2023 · 0 comments
Open

Network issues are hidden by the install script #122

13steinj opened this issue Jul 15, 2023 · 0 comments

Comments

@13steinj
Copy link

13steinj commented Jul 15, 2023

See

@staticmethod
def run(*args, **kwargs) -> subprocess.CompletedProcess:
completed_process = subprocess.run(
args,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
**kwargs,
)
if completed_process.returncode != 0:
raise PoetryInstallationError(
return_code=completed_process.returncode,
log=completed_process.stdout.decode(),
)
return completed_process

The above configuration means "stdout to pipe, stderr matches stdout".
If you're having network issues, this installer either completely obscures or significantly delays the reporting of said errors.
I never let it run it completion, but the network issues were significant enough that it was running for several hours (this was with default configuration, outside of being behind an org proxy + pip.conf pointing to an org mirror of pypi).

Personally, I think it's fine just to log to the console all stdout and stderrr from PIP as it happens.
Might be good to log individual process stages of the environment's creation as well (so you can know if you have other issues with your system).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant