Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script prints misleading message when you already have the version specified by --version #117

Open
4 tasks done
seansfkelley opened this issue May 30, 2023 · 0 comments

Comments

@seansfkelley
Copy link

seansfkelley commented May 30, 2023

  • Poetry version: 1.5.1
  • Python version: 3.9.16
  • OS version and name: macOS 13.2.1
  • pyproject.toml: n/a
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When installing Poetry from the curl'able script, it conflates "already have requested version" and "already have latest version", which is misleading. An example terminal session:

$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0

[ snip ]

Installing Poetry (1.5.0): Done

Poetry (1.5.0) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`


$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0
Retrieving Poetry metadata

The latest version (1.5.0) is already installed.


$ curl -sSL https://install.python-poetry.org | python3.9 -

[ snip ]

Installing Poetry (1.5.1): Done

Poetry (1.5.1) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`

1.5.1 is latest, but when I reinstall 1.5.0 explicitly, it calls it the "latest version (1.5.0)".

This was briefly misleading as I was fixing some install issues on my project this morning. The issues themselves were resolved by upgrading Poetry, but I didn't realize at first that this was an option because this version pinning was being done by a set-everything-up script and the logging, of course, implied that upgrading Poetry was not a potential solution.

I would suggest splitting the logging into a two branches for clarity:

  • The requested version (x.y.z) is already installed. The latest version is a.b.c.
  • The latest version (x.y.z) is already installed.
@seansfkelley seansfkelley changed the title Install script prints misleading error message when you already have the version specified by --version Install script prints misleading message when you already have the version specified by --version May 30, 2023
@Secrus Secrus transferred this issue from python-poetry/poetry May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant