Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will be the time to drop Python 2 compatibility? #274

Closed
nathanielmanistaatgoogle opened this issue Aug 14, 2024 · 2 comments · Fixed by #277
Closed

When will be the time to drop Python 2 compatibility? #274

nathanielmanistaatgoogle opened this issue Aug 14, 2024 · 2 comments · Fixed by #277

Comments

@nathanielmanistaatgoogle

I recently attempted to use one of my favorite static analysis tools with hpack and it choked on

try:  # pragma: no cover
    basestring = basestring
except NameError:  # pragma: no cover
    basestring = (str, bytes)

in hpack.py because it doesn't support analyzing Python 2 source. My impression at this time is that this isn't a problem with the tool; that more than four years after the Python 2 turndown it's appropriate for tools to drop support for analyzing Python 2 source.


So... while I see that https://hyper.readthedocs.io/en/latest advertises that the hyper family of projects supports 2.7.9-and-later in the Python 2 line, do y'all hyper maintainers have a notion of when you're going to be dropping Python 2 compatibility from the source?

@Kriechi
Copy link
Member

Kriechi commented Aug 14, 2024

Sounds good to me! Happy to review a PR, though not sure when we will ship the next major release to include the change.

@nathanielmanistaatgoogle
Copy link
Author

Apologies that I didn't get to this on my own, and thanks much for the change! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants