Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass hide_parameters into GinoEngine #798

Open
FNSdev opened this issue Oct 13, 2021 · 0 comments
Open

Allow to pass hide_parameters into GinoEngine #798

FNSdev opened this issue Oct 13, 2021 · 0 comments

Comments

@FNSdev
Copy link

FNSdev commented Oct 13, 2021

Hello!

Is your feature request related to a problem? Please describe.
I would like to utilize hide_parameters argument from the SQLAlchemy engine, but it seems like it's not possible right now, because GinoEngine does not have such a kwarg, so I get a TypeError from here:

class GinoStrategy:

    async def create(self, name_or_url, loop=None, **kwargs):
       ....

        # all kwargs should be consumed
        if kwargs:
            raise TypeError(
                "Invalid argument(s) %s sent to create_engine(), "
                "using configuration %s/%s.  Please check that the "
                "keyword arguments are appropriate for this combination "
                "of components."
                % (
                    ",".join("'%s'" % k for k in kwargs),
                    dialect_cls.__name__,
                    engine_cls.__name__,
                )
            )

Describe the solution you'd like
Make it possible to pass hide_parameters into GinoEngine __init__.

Describe alternatives you've considered

Additional context

I am using Gino 1.0.1 and SQLALchemy 1.3.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant