Make !warn fail if DMing the user is unsuccessful #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekashok1221
force-pushed
the
vivek/warn-dm-fail
branch
from
a058959
to
73a593f
Compare
vivekashok1221
commented
May 24, 2024
Comment on lines
+255
to
+256
| confirm_msg = (f":x: Failed to apply **warning** to {user.mention} " | ||
| "because DMing the user was unsuccessful") |
There was a problem hiding this comment.
I'm open to changing this to something else like "Failed to apply warning to @mention because the user has their DMs disabled".
I chose the current message because I felt it accounted for cases where users block the bot too, but I realize the distinction is irrelevant.
wookie184
added
the
s: needs review
MarkKoz
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1352
I've made it so that
!warnwill fail if the user has their DMs disabled (or has blocked the bot) AND the command was invoked in a "private" channel which the user does not have access to.