Skip to content

Passing these=d to attr.s skips attributes defined in class body #621

Description

@perkinslr
@attr.s(these=dict(a=attr.ib()))
class test:
    b: int = attr.ib(default=0)

c = test(5)
print(c.b)

This fails even if passing auto_attribs=True, albeit in a slightly different way.

The obvious workaround is to only put attributes in these, but that is harder for code analysis tools to understand (it lacks type annotations, even if the tools are attrs aware).

The second workaround would be to put the attributes from these into the class body, but that doesn't work if the attribute is inherited or describe a data descriptor (like getter/setters).

The final workaround is to duplicate the definition into both these and the class body, but that creates an opportunity for the two to get out of sync.

Anyway, ideally, attrs would add anything from the class body which is an instance of _CountingAttr, (and anything from the annotations dict if auto_attribs is set). If that is not practical, then a warning or exception should be raised rather than having weird runtime behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions