Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_failed_first_last_failed → NotImplementedError #41

Open
Natim opened this issue Feb 26, 2020 · 5 comments
Open

process_failed_first_last_failed → NotImplementedError #41

Natim opened this issue Feb 26, 2020 · 5 comments

Comments

@Natim
Copy link

Natim commented Feb 26, 2020

I often encounter this exception, especially when I previously ran pytest and a syntax error prevented it to run.

File "/usr/local/lib/python3.7/site-packages/random_order/plugin.py", line 60, in pytest_collection_modifyitems
INTERNALERROR>     process_failed_first_last_failed(session, config, items)
INTERNALERROR>   File "/usr/local/lib/python3.7/site-packages/random_order/cache.py", line 28, in process_failed_first_last_failed
INTERNALERROR>     raise NotImplementedError()
INTERNALERROR> NotImplementedError
@jbasko
Copy link
Collaborator

jbasko commented Feb 26, 2020

  1. Do you have a name of the test that caused this?
  2. Is that a method in a test class or a plain test function?

I'm asking because the issue is to do with the parsing of the name of the failed test in the cache plugin's lastfailed.

@Natim
Copy link
Author

Natim commented Feb 27, 2020

Oh interesting. Let me dig that information for you.

@Natim
Copy link
Author

Natim commented Feb 27, 2020

Is it possible that it is the case when pytest is run on tests that don't include the file in question? I run pytest 3 times in a raw and I have the issue if pytest is ran without the erroneous file.

@jbasko
Copy link
Collaborator

jbasko commented Feb 29, 2020

I just tried removing the test or test module that has last failed and then running with --last-failed and was not able to reproduce the error. If you could edit locally that raise NotImplementedError() line to include more information that would help. It's my bad to raise such an uninformative exception.

@ssbarnea
Copy link
Member

Today I found the same bug on a project but it happened only once, very weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants