Allow colon to be used in test id

Fixes: ansible/ansible-compat#340
pytest-dev · Jan 10, 2024 · 0b75c64 · 0b75c64
1 parent 6ff466a
commit 0b75c64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/pytest_plus/__init__.py b/src/pytest_plus/__init__.py
@@ -18,7 +18,7 @@ def get_max_test_id_length() -> int:
 def get_test_id_regex() -> None | re.Pattern[str]:
  """Return regex to use for checking test ids."""
  if int(os.environ.get("PYTEST_CHECK_TEST_ID_REGEX", "1")):
- return re.compile(r"^[\w_\-\.]+$")
+ return re.compile(r"^[\w_\-\.:]+$")
  return None
 
 

diff --git a/test/test_plugin.py b/test/test_plugin.py
@@ -60,7 +60,7 @@ def test_a(some: str):
  result = pytester.runpytest_inprocess("--collect-only", p1)
  if not disable:
  assert (
- "Test <Function test_a[invalid name]> has an id that does not match our safe pattern '^[\\w_\\-\\.]+$' for use with a terminal."
+ "Test <Function test_a[invalid name]> has an id that does not match our safe pattern '^[\\w_\\-\\.:]+$' for use with a terminal."
  in result.stderr.lines
  )
  assert result.ret == rc