Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spopt sub-sub modules not included on PyPI? #128

Closed
jGaboardi opened this issue Jan 17, 2021 · 10 comments
Closed

spopt sub-sub modules not included on PyPI? #128

jGaboardi opened this issue Jan 17, 2021 · 10 comments

Comments

@jGaboardi
Copy link
Member

Currently the PyPI published v0.0.3 and v0.0.2 do not include region, locate, or transport. However, the PyPI publishedv0.0.1 and the GitHub releases do include them. This problem is causing the failure in conda-forge/staged-recipes#13708.

My first thought is that there is an issue with our release_and_publish.yml.

See also #118

@sjsrey
Copy link
Member

sjsrey commented Jan 17, 2021

Why do we have locate and transport if those do not yet have any functionality?

@jGaboardi
Copy link
Member Author

They were part of the directory structure, albeit simply place holders with __init__.py files for the time being. Should we remove for the time being?

@sjsrey
Copy link
Member

sjsrey commented Jan 17, 2021

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

@knaaptime
Copy link
Member

Huh. I tried that same check yesterday and it worked, though I didn’t look to see which version. My best guess would be something related to manifest. Will keep digging today

@sjsrey
Copy link
Member

sjsrey commented Jan 17, 2021

Aspirational goals/plans should get moved into a roadmap document on the site

@jGaboardi
Copy link
Member Author

I think it might confuse users and/or lead to installation mysteries of the kind we are currently trying to debug :->

OK. I will remove them from the directory and create an issue to add them back later.

@sjsrey
Copy link
Member

sjsrey commented Jan 17, 2021

Testing a local build, the tarball gets:

 ❯ tar xzvf spopt-0.0.4.tar.gz                                           [09:27:22]
spopt-0.0.4/
spopt-0.0.4/LICENSE.txt
spopt-0.0.4/MANIFEST.in
spopt-0.0.4/PKG-INFO
spopt-0.0.4/README.md
spopt-0.0.4/requirements.txt
spopt-0.0.4/requirements_dev.txt
spopt-0.0.4/requirements_docs.txt
spopt-0.0.4/requirements_tests.txt
spopt-0.0.4/setup.cfg
spopt-0.0.4/setup.py
spopt-0.0.4/spopt/
spopt-0.0.4/spopt/BaseClass.py
spopt-0.0.4/spopt/__init__.py
spopt-0.0.4/spopt.egg-info/
spopt-0.0.4/spopt.egg-info/PKG-INFO
spopt-0.0.4/spopt.egg-info/SOURCES.txt
spopt-0.0.4/spopt.egg-info/dependency_links.txt
spopt-0.0.4/spopt.egg-info/not-zip-safe
spopt-0.0.4/spopt.egg-info/requires.txt
spopt-0.0.4/spopt.egg-info/top_level.txt

so something is not correct in the setup.py?

@jGaboardi
Copy link
Member Author

there was no problem when I did the first manual release on PyPI or with the tagged releases here on GH. the problem was only introduced when I started using the release action and #129 may solve the problem.

@sjsrey
Copy link
Member

sjsrey commented Jan 17, 2021

Just to be clear, a python setup.py sdist is not grabbing any of the submodules, so I think that is part of the problem (orthogonal to the release actions)

@jGaboardi
Copy link
Member Author

solved in #131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants