Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spaghetti should handle native cg.Point/Chain objects #217

Closed
9 tasks done
jGaboardi opened this issue Dec 15, 2018 · 2 comments
Closed
9 tasks done

spaghetti should handle native cg.Point/Chain objects #217

jGaboardi opened this issue Dec 15, 2018 · 2 comments
Assignees
@jGaboardi
Labels
enhancement priority-high
Milestone
Release v1.4.1

Comments

@jGaboardi
Copy link
Member

jGaboardi commented Dec 15, 2018 •
edited
Loading

Currently, input for instantiating a network.Network and network.PointPattern can be accomplished with either a .shp file or a geopandas.GeoDataFrame. However, passing in native pysal.cg objects is not an option. As spaghetti is a member of the pysal federation, this functionality should be available.

  • network.Network accepts cg.Chain objects for instantiation
  • network.PointPattern accepts cg.Point objects for instantiation

Tests

  • tests/test_network.py -- test_network_from_cg(self)
    • cg test against known
    • shp against cg
  • tests/test_network_api.py -- test_network_from_cg(self)
    • cg test against known
    • shp against cg

Docs

  • re-run docs
@jGaboardi jGaboardi self-assigned this Dec 15, 2018
@jGaboardi jGaboardi added this to the Release v1.4.1 milestone Jan 12, 2020
@jGaboardi jGaboardi mentioned this issue Jan 12, 2020
Merged
@jGaboardi
Copy link
Member Author

jGaboardi commented Jan 12, 2020 •
edited
Loading

#377

@jGaboardi jGaboardi mentioned this issue Jan 16, 2020
Closed
@jGaboardi
Copy link
Member Author

#380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
enhancement priority-high
Projects
None yet
Milestone
Release v1.4.1
Development

No branches or pull requests
1 participant
@jGaboardi